Add transaction submission failure hook and error handling by GabrielMartinezRodriguez · Pull Request #366 · HappyChainDevs/happychain

GabrielMartinezRodriguez · 2025-01-22T16:22:35Z

Linked Issues

closes https://linear.app/happychain/issue/HAPPY-282/hook-to-notify-the-library-user-about-issues-before-submitting-their

Description

Creating a new TransactionSubmissionFailed hook to capture submission failures
Adding error logging for transaction submission failures in the randomness service

Toggle Checklist

Checklist

Basics

B1. I have applied the proper label & proper branch name (e.g. norswap/build-system-caching).
B2. This PR is not so big that it should be split & addresses only one concern.
B3. The PR targets the lowest branch it can (ideally master).

Correctness

C1. Builds and passes tests.
C2. The code is properly parameterized & compatible with different environments.
C3. I have manually tested my changes & connected features.
C4. I have performed a thorough self-review of my code after submitting the PR.

Architecture & Documentation

D1. I made it easy to reason locally about the code.
D2. All public-facing APIs & meaningful internal APIs are properly documented.
D3. If appropriate, the general architecture is documented.

GabrielMartinezRodriguez · 2025-01-22T16:23:22Z

Deploy randomness service #416 : 2 dependent PRs (#434 , #441 )
Add config contract #404
Randomness service: Improve performance and reliability #372
Add transaction submission failure hook and error handling #366 👈 (View in Graphite)
Increase default RPC timeout to 2000ms #365
Add configurable HTTP polling interval for block monitoring #362
Force initialization before using the TXM #361
Script to monitor randomness service #325
Script to easily launch the randomness service locally #324
Submit drand numbers #318
Random oracle contracts #307
Only prune finalized randomness entries #305
Add NewBlock hook #304
Refactors the randomness service to be able to process pending commitments #303
Add SQLite persistence to randomness service #300
Txm no longer receives Viem objects #298 : 1 other dependent PR (#299 )
Add flush mechanism #289 : 1 other dependent PR (#297 )
Allow run multiple txm simultaneously within the same service #285
Added docs for txm #272
Mutex in tx monitor #264
Purge transactions #232
Txm hooks #229
Use kysely instead of mikro-orm #250
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

cloudflare-workers-and-pages · 2025-01-22T16:24:06Z

Deploying happychain with Cloudflare Pages

Latest commit:	`2c9bf41`
Status:	✅ Deploy successful!
Preview URL:	https://dd973ade.happychain.pages.dev
Branch Preview URL:	https://gabriel-txm-submission-faile.happychain.pages.dev

View logs

linear · 2025-01-22T16:27:18Z

HAPPY-282 Hook to notify the library user about issues before submitting their transactions.

We want to notify users about potential issues that may occur before submitting their transactions, such as problems encountered when simulating a transaction. These issues could result in the transaction remaining indefinitely in our database while attempting to be included, without notifying the user.

Another good idea would be to implement a system that allows users to modify the parameters of such transactions to resolve these issues, for example, by changing the call data. Additionally, it should also be possible for users to remove these transactions.

norswap · 2025-02-09T21:28:21Z

packages/txm/lib/TransactionCollector.ts

+                    eventBus.emit(Topics.TransactionSubmissionFailed, {
+                        transaction,
+                        description: submissionResult.error.description,
+                    })


Seems like a good idea to also pass the cause from the AttemptSubmissionErrorCause enum (and export that publicly) so that might enable finer-grained reaction to this without needing to parse the description.

…ons fails

…Failed hook

GabrielMartinezRodriguez changed the title ~~feat(txm): add transaction submission failure hook and error handling~~ Add transaction submission failure hook and error handling Jan 22, 2025

This was referenced Jan 22, 2025

Force initialization before using the TXM #361

Merged

Add configurable HTTP polling interval for block monitoring #362

Merged

Increase default RPC timeout to 2000ms #365

Merged

GabrielMartinezRodriguez marked this pull request as ready for review January 22, 2025 16:25

GabrielMartinezRodriguez self-assigned this Jan 22, 2025

GabrielMartinezRodriguez added the reviewing-1 Ready for, or undergoing first-line review label Jan 22, 2025

GabrielMartinezRodriguez force-pushed the gabriel/txm-increase-timeout branch from 8e4376e to a7c5995 Compare January 22, 2025 16:39

GabrielMartinezRodriguez force-pushed the gabriel/txm-submission-failed-hook branch from 8cfe729 to f8117b9 Compare January 22, 2025 16:39

GabrielMartinezRodriguez force-pushed the gabriel/txm-increase-timeout branch from a7c5995 to f238ce6 Compare January 23, 2025 10:38

GabrielMartinezRodriguez force-pushed the gabriel/txm-submission-failed-hook branch from f8117b9 to a98fbb3 Compare January 23, 2025 10:38

GabrielMartinezRodriguez mentioned this pull request Jan 23, 2025

Randomness service: Improve performance and reliability #372

Merged

10 tasks

GabrielMartinezRodriguez force-pushed the gabriel/txm-increase-timeout branch from f238ce6 to 6ddafa5 Compare January 23, 2025 14:45

GabrielMartinezRodriguez force-pushed the gabriel/txm-submission-failed-hook branch from a98fbb3 to 82a0cb6 Compare January 23, 2025 14:45

not-reed approved these changes Jan 23, 2025

View reviewed changes

GabrielMartinezRodriguez force-pushed the gabriel/txm-increase-timeout branch from 6ddafa5 to 352683b Compare January 31, 2025 14:44

GabrielMartinezRodriguez force-pushed the gabriel/txm-submission-failed-hook branch from 82a0cb6 to 98067ed Compare January 31, 2025 14:44

GabrielMartinezRodriguez mentioned this pull request Feb 3, 2025

Add config contract #404

Merged

10 tasks

GabrielMartinezRodriguez force-pushed the gabriel/txm-increase-timeout branch from 352683b to 0303189 Compare February 3, 2025 12:41

GabrielMartinezRodriguez force-pushed the gabriel/txm-increase-timeout branch from 0303189 to 6123c34 Compare February 3, 2025 13:15

GabrielMartinezRodriguez force-pushed the gabriel/txm-submission-failed-hook branch from 70e6dc4 to 55a5c0a Compare February 3, 2025 13:16

GabrielMartinezRodriguez force-pushed the gabriel/txm-increase-timeout branch from 6123c34 to 440728c Compare February 4, 2025 13:51

GabrielMartinezRodriguez force-pushed the gabriel/txm-submission-failed-hook branch from 55a5c0a to 6749747 Compare February 4, 2025 13:51

GabrielMartinezRodriguez force-pushed the gabriel/txm-increase-timeout branch from 440728c to 877ca68 Compare February 5, 2025 14:03

GabrielMartinezRodriguez force-pushed the gabriel/txm-submission-failed-hook branch from 6749747 to f5a61b6 Compare February 5, 2025 14:03

GabrielMartinezRodriguez mentioned this pull request Feb 5, 2025

Deploy randomness service #416

Merged

10 tasks

aodhgan added reviewing-2 Ready for, or undergoing final review and removed reviewing-1 Ready for, or undergoing first-line review labels Feb 6, 2025

norswap reviewed Feb 9, 2025

View reviewed changes

norswap approved these changes Feb 9, 2025

View reviewed changes

norswap added merge-blocked-after-changes Ready to merge but waiting for downstack, after requested changes are made and removed reviewing-2 Ready for, or undergoing final review labels Feb 9, 2025

norswap force-pushed the gabriel/txm-increase-timeout branch from 877ca68 to fab80c3 Compare February 10, 2025 20:23

norswap force-pushed the gabriel/txm-submission-failed-hook branch from f5a61b6 to 05dc512 Compare February 10, 2025 20:23

GabrielMartinezRodriguez force-pushed the gabriel/txm-increase-timeout branch from fab80c3 to 4722d38 Compare February 10, 2025 20:25

Base automatically changed from gabriel/txm-increase-timeout to master February 10, 2025 20:31

GabrielMartinezRodriguez added 3 commits February 10, 2025 21:33

feat(txm): added hook to notify lib users when a transaction submissi…

c5f5cf4

…ons fails

chore(txm): increase timeout

e282b29

chore(txm): send AttemptSubmissionErrorCause in TransactionSubmission…

b9ba93f

…Failed hook

GabrielMartinezRodriguez force-pushed the gabriel/txm-submission-failed-hook branch from 05dc512 to b9ba93f Compare February 10, 2025 20:33

chore(txm): export AttemptSubmissionErrorCause

2c9bf41

GabrielMartinezRodriguez added merge-blocked Ready to merge, waiting for downstack and removed merge-blocked-after-changes Ready to merge but waiting for downstack, after requested changes are made labels Feb 10, 2025

GabrielMartinezRodriguez merged commit 597fa82 into master Feb 10, 2025
3 checks passed

GabrielMartinezRodriguez deleted the gabriel/txm-submission-failed-hook branch February 10, 2025 20:43

This was referenced Feb 11, 2025

Added Interrupted status to transaction entity #434

Merged

debug #435

Closed

Implemented block inactivity timeout #441

Merged

GabrielMartinezRodriguez mentioned this pull request Feb 25, 2025

Fix: random() reverts once every 3 blocks #458

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add transaction submission failure hook and error handling#366

Add transaction submission failure hook and error handling#366
GabrielMartinezRodriguez merged 4 commits intomasterfrom
gabriel/txm-submission-failed-hook

GabrielMartinezRodriguez commented Jan 22, 2025 •

edited

Loading

Uh oh!

GabrielMartinezRodriguez commented Jan 22, 2025 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages bot commented Jan 22, 2025 •

edited

Loading

Uh oh!

linear bot commented Jan 22, 2025

Uh oh!

norswap Feb 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

GabrielMartinezRodriguez commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Linked Issues

Description

Checklist

Basics

Correctness

Architecture & Documentation

Uh oh!

GabrielMartinezRodriguez commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cloudflare-workers-and-pages bot commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying happychain with Cloudflare Pages

Uh oh!

linear bot commented Jan 22, 2025

Uh oh!

norswap Feb 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

GabrielMartinezRodriguez commented Jan 22, 2025 •

edited

Loading

GabrielMartinezRodriguez commented Jan 22, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 22, 2025 •

edited

Loading